Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Allow the ability to save the graph. #3

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SimonRichardson
Copy link

This is a PR to fix #1, there are some limitations outlined bellow and I'll see if I can fix the transparent image later on.

Limitations: Currently FF saves with incorrect image extension and
the background of the image is transparent (will fix later).

Limitations: Currently FF saves with incorrect image extension and
the background of the image is transparent (will fix later).
@davecheney
Copy link
Owner

Nice!

Can you hold off for an hour or so, I'm trying to push a change that adds
the ability to zoom in on a part of the graph, you'll need to merge with
that.

On Fri, Jul 11, 2014 at 7:25 PM, Simon Richardson notifications@github.com
wrote:

This is a PR to fix #1 https://github.com/davecheney/gcvis/issues/1,
there are some limitations outlined bellow and I'll see if I can fix the
transparent image later on.

Limitations: Currently FF saves with incorrect image extension and

the background of the image is transparent (will fix later).

You can merge this Pull Request by running

git pull https://github.com/SimonRichardson/gcvis master

Or view, comment on, or merge it at:

#3
Commit Summary

  • Allow the ability to save the graph.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#3.

@SimonRichardson
Copy link
Author

Sure, no problems :)

@davecheney
Copy link
Owner

Do you want to pull #4 and resend this PR. Sorry for the crappy merge.

@SimonRichardson
Copy link
Author

I've added the ability to see what's the gc is doing in some sort of delayed fashion. Essentially we poll the /ajax endpoint to retrieve the updates from the gc.

@davecheney
Copy link
Owner

@SimonRichardson i'm sorry for not replying earlier. If you are still interested in landing this PR, please fix the merge conflicts and I'll merge it for you.

@tonglil
Copy link

tonglil commented Feb 27, 2016

Perhaps this could be done with less code changes from the client-side like such: http://stackoverflow.com/questions/15616925/save-flot-graph-as-image?

@davecheney
Copy link
Owner

@tonglil if you want to fix the conflicts, I'll be happy to review this branch.

@holys
Copy link

holys commented Jun 28, 2016

Why not just cmd + p if you are using Mac and open it in Preview?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants